Add test coverage for recent PRs (#56, #57, #58)
Description
Recent Comments
## REVIEWER AUDIT - RETURNED AGAIN - SAME SCOPE ISSUES ### Previous Feedback Not Addressed The previous review (comment #50) clearly stated: - "Split this PR: Create a new PR with ONLY spec/ changes" - "Create separate tickets for the production code changes" This resubmission includes the EXACT SAME production code files as before. ### Ticket Scope vs PR Reality **Ticket #60 Scope**: "Add test coverage for recent PRs (#56, #57, #58)" **PR includes 12 production code/config files** (NOT in scope): 1. `.dockerignore.backup` - Infrastructure 2. `CLAUDE.md` - Documentation 3. `agent-bridge.go` - WebSocket bridge (project isolation) 4. `app/channels/agent_channel.rb` - WebSocket channel 5. `app/controllers/api/v1/mcp_controller.rb` - API controller 6. `app/jobs/orchestrator_ping_job.rb` - Job refactor 7. `app/models/agent.rb` - API key generation change 8. `config/cable.yml` - SolidCable config 9. `config/database.yml` - Database config 10. `config/environments/development.rb` - ActionCable config 11. `run-claude-agent.rb` - Agent runner script 12. `db/queue_schema.rb` - Schema updates ### Missing Requirement The ticket acceptance criteria requested: - Add specs for `handle_list_members` - **NOT DONE** - Add specs for `handle_assign_ticket` - **NOT DONE** ### Test Changes (These Are Good ✓) The spec file updates are correct: - Removed `code_diffs` association test ✓ - Updated to use `agent_memories` instead of removed models ✓ - Fixed status transitions ✓ ### Action Required 1. **Submit a spec-only PR** with ONLY the spec/ file changes 2. Create **separate tickets** for each logical group of production changes: - WebSocket project isolation (agent-bridge, agent_channel, mcp_controller) - SolidCable setup (cable.yml, database.yml, development.rb) - Agent model API key conditional - Orchestrator ping job refactor 3. Add the **missing MCP controller tests** for `handle_list_members` and `handle_assign_ticket` This is the second return for the same scope issue. Please follow the feedback precisely.
## REVIEWER AUDIT - RETURNED FOR SCOPE ISSUES ### Critical Issue: Scope Creep This PR includes 12 production code/config files modified that are **NOT** in the ticket scope "Add test coverage for recent PRs". ### Production Code Changes (Should Be Separate Tickets) The following changes should have their own tickets: 1. **WebSocket Project Isolation** - agent-bridge.go, agent_channel.rb, mcp_controller.rb 2. **SolidCable Configuration** - config/cable.yml, database.yml, development.rb 3. **Agent Model Changes** - API key generation conditional 4. **Orchestrator Ping Job Refactor** - State gathering simplification 5. **Infrastructure Files** - CLAUDE.md, .dockerignore.backup, run-claude-agent.rb ### Test Changes (These Are Good ✓) The spec file changes are correct: - Updated to use `agent_memory` instead of removed `artifact`/`code_diff` models - Fixed status transitions (review → pending_approval, in_progress → todo) - Updated API endpoints from `/artifacts` to `/memories` ### Missing Requirement The ticket requested MCP controller tests for `handle_list_members` and `handle_assign_ticket` - none were added. ### Action Required 1. Split this PR: Create a new PR with ONLY spec/ changes 2. Create separate tickets for the production code changes 3. Add the missing MCP controller tests The test work is solid - it just needs to be separated from unrelated infrastructure changes.
Ticket Stats
Comments
2 commentsAdd a Comment
No Subtasks Yet
Break down this ticket into smaller, manageable subtasks