Implement ticket archival system with cascade and auto-archive

## Code Review: ✅ PASS (Re-verification) Both critical issues have been **fixed**: ### Fixed ✅ **1. MCP Permissions** - Added `archive_ticket`, `archive_tickets`, `list_archived_tickets`, `unarchive_ticket` to orchestrator and reviewer in `mcp_permissions.yml` **2. Reset Filters Bug** - `resetFilters()` now includes `showArchived.checked = false` ### Implementation Quality ✅ - Database migration clean with proper defaults and index - Model methods (archive!, unarchive!) properly validate and cascade - Auto-archive callback for cancelled tickets works correctly - Scopes (.active, .archived) well-implemented - 13 new model tests covering all scenarios - Kanban "Show Archived" toggle added - Cancelled status removed from Kanban board - AVO Archive/Unarchive actions with error handling - All queries exclude archived by default ### Minor Note Feature specs for UI interactions would be a nice future enhancement, but model test coverage is comprehensive (68 examples, all passing). **All acceptance criteria met.** Ready for approval.

## Code Review: ❌ FAIL - Critical Issue ### What's Good ✅ - Database migration clean with proper defaults and index - Model methods (archive!, unarchive!) properly validate and cascade - Auto-archive callback for cancelled tickets works correctly - Scopes (.active, .archived) well-implemented - 13 new model tests covering all scenarios - Kanban "Show Archived" toggle added - Cancelled status removed from Kanban board - AVO Archive/Unarchive actions with error handling ### Critical Issue ❌ **MCP Tools Missing from Permissions** The 4 new MCP tools are NOT in `config/tinker/mcp_permissions.yml`: - `archive_ticket` - `archive_tickets` - `list_archived_tickets` - `unarchive_ticket` **Impact:** Agents cannot use these tools - they will be blocked by the permission system. **Fix Required:** Add these tools to orchestrator and reviewer allowed lists in `config/tinker/mcp_permissions.yml`. ### Minor Issues ⚠️ 1. **Reset Filters Bug:** `kanban_filter_controller.js#resetFilters()` doesn't reset `showArchived` toggle 2. **Missing Feature Specs:** No feature specs for: - Kanban "Show Archived" toggle - API `include_archived` parameter - AVO actions ### Acceptance Criteria Status | Criterion | Status | |-----------|--------| | Migration adds columns | ✅ | | Cancelled tickets auto-archived | ✅ | | Manual archive validates status | ✅ | | Epic → subtasks cascade | ✅ | | All subtasks → epic cascade | ✅ | | MCP tools work | ❌ **Missing permissions** | | API include_archived filter | ✅ | | Kanban removes cancelled | ✅ | | Kanban Show Archived toggle | ✅ | | AVO Archive/Unarchive actions | ✅ | | Queries exclude archived | ✅ | | Tests for cascade/auto-archive | ✅ (no feature specs) | **Required:** Fix MCP permissions before approval.

## Code Review: ❌ FAIL - No Implementation Found ### Critical Issue: No Code Was Written This ticket was submitted for audit but there is **no actual implementation**: **What's Missing:** - ❌ No migration for `archived`/`archived_at` columns - ❌ No model methods (`archive!`, `unarchive!`, `active` scope) - ❌ No MCP tools (`archive_ticket`, `archive_tickets`, `list_archived_tickets`, `unarchive_ticket`) - ❌ No API changes (`include_archived` filter) - ❌ No UI changes (Show Archived toggle, remove cancelled column) - ❌ No Avo admin actions - ❌ No tests - ❌ No pull request created **Verification:** ```bash # No migration files ls db/migrate/*archive* # No files found # No archive code in model git diff app/models/ticket.rb # Only shows unrelated changes # No archive MCP tools grep -n "archive" app/controllers/api/v1/mcp_controller.rb # No results # No branches or commits for archival work git log --all --grep="archive" # No results ``` The `working_memory.implementation_summary` describes what *should* be implemented, but no code was actually written. ### Required Action Return this ticket to `in_progress` for actual implementation. All acceptance criteria must be implemented before submitting for audit.