Fix bare HTTP status check warnings in specs

Tinker

Home Epics Fix bare HTTP status check warnings in specsEdit

Cancel

Title *

Project *

Description

The codebase has a `bare_status_check_enforcer.rb` that warns when `have_http_status` is used without also checking the response body. This is important because bare status checks hide debugging information when tests fail.

When running specs, warnings are displayed for files that use bare `have_http_status` checks. These need to be replaced with the appropriate matchers from `response_matchers.rb`:

- For API success (200 JSON): use `have_api_success` or `expect_api_success`
- For API errors (401, 404, 422, etc. with JSON): use `have_api_error` or `expect_api_error`
- For non-API success (200 HTML/text): use `have_successful_response`
- For non-API errors (401, 404, etc. HTML/text): use `have_error_response` or `expect_error_response`

Files to check (found via grep):
- spec/requests/api/v1/tickets_spec.rb
- spec/requests/api/v1/mcp_spec.rb
- spec/requests/proposals_spec.rb
- spec/requests/multi_agent_coordination_spec.rb
- spec/requests/complete_workflow_spec.rb
- spec/requests/memory_management_spec.rb
- spec/requests/api/v1/terminal_spec.rb
- spec/requests/security_spec.rb
- spec/controllers/api/v1/assignments_controller_spec.rb
- spec/controllers/api/v1/tickets_controller_spec.rb
- spec/controllers/api/v1/comments_controller_spec.rb
- spec/controllers/api/v1/projects_controller_spec.rb
- spec/controllers/api/v1/memories_controller_spec.rb

Acceptance criteria:
1. Run the full test suite and capture all bare HTTP status check warnings
2. Replace each bare `have_http_status` check with the appropriate matcher that also validates the response body
3. Verify no warnings are displayed when running specs again